Merged
Conversation
ctrueden
force-pushed
the
stream-locations
branch
2 times, most recently
from
d6ecb02 to
082fc60
Compare
ctrueden
requested changes
Oct 15, 2018
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Thanks @gab1one! This is looking good.
There are/were three problems, the first two of which I already fixed:
- Misspelling of
cutoff(only has one T). - Compile errors with
DefaultBufferedStreamHandlecallingByteBank.getMaxPos()(it was changed toByteBank.size()), and missingexists()method implementation. - No unit tests for
DefaultBufferedStreamHandle.
For (1) and (2), I fixed and force pushed the relevant commits.
For (3), could you please add a test?
The findString(..) method used to require the exact length of the handle, this length can be unknown, e.g. for compressed handles. This is no longer the case.
Contributor
Author
|
Thanks for fixing this, |
gab1one
force-pushed
the
stream-locations
branch
from
082fc60 to
15fc988
Compare
added 2 commits
October 16, 2018 15:16
This basic version does not fully support random access, which will be provided by subclasses to be added in future commits.
These subinterfaces of StreamHandle provide random access over the contained streams.
Contributor
Author
|
I am actually not sure if we need the |
gab1one
force-pushed
the
stream-locations
branch
2 times, most recently
from
9de55e6 to
8376a59
Compare
added 2 commits
October 16, 2018 16:56
Some handles don't know their length and instead return -1, this commit adds an option to the length check to assure this.
gab1one
force-pushed
the
stream-locations
branch
from
8376a59 to
183c2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are currently used for Compressed input streams #274 and https://github.com/scijava/scijava-io-http